This article examines the discourses of English teaching, and their implications for subject and literacy teaching and learning. Case study evidence is presented to illustrate the ways in which competing discourses are enacted in the classroom. We argue the need to critically examine the educational value of teacher discourses, which have an important impact on instructional practices and the quality of pupils’ learning.